*** cods <cods!~fred@82-65-232-44.subs.proxad.net> has quit IRC (Ping timeout: 246 seconds) | 00:37 | |
*** cods <cods!~fred@82-65-232-44.subs.proxad.net> has joined #bzflag | 00:38 | |
*** FastLizard4 is back | 02:57 | |
*** FastLizard4 is now away: AWAY from keyboard | 04:03 | |
*** _I_Died_Once <_I_Died_Once!~I_Died_On@c-73-184-170-223.hsd1.ga.comcast.net> has quit IRC (Ping timeout: 260 seconds) | 05:33 | |
*** FastLizard4 is back | 07:23 | |
*** FastLizard4 is now away: AWAY from keyboard | 08:05 | |
*** FastLizard4 is now away: GONE - Screen Detached and Disconnected from IRC (I'm probably asleep, at work, or doing something in real life) | 08:31 | |
*** Sgeo <Sgeo!~Sgeo@user/sgeo> has quit IRC (Read error: Connection reset by peer) | 09:31 | |
*** _I_Died_Once <_I_Died_Once!~I_Died_On@c-73-184-170-223.hsd1.ga.comcast.net> has joined #bzflag | 10:55 | |
*** FastLizard4 <FastLizard4!fastlizard@wikipedia/FastLizard4> has quit IRC (*.net *.split) | 11:30 | |
*** FastLizard4 <FastLizard4!fastlizard@wikipedia/FastLizard4> has joined #bzflag | 11:35 | |
*** FastLizard4 is now away: GONE - Screen Detached and Disconnected from IRC (I'm probably asleep, at work, or doing something in real life) | 11:35 | |
*** Cobra_Fast is now away: offline | 11:54 | |
*** Cobra_Fast is back | 11:54 | |
*** Cobra_Fast is now away: offline | 12:04 | |
*** Cobra_Fast is back | 12:04 | |
tupone | looking at code in src/bzfs/CustomMesh.cxx I think this is not sane --- const_cast<std::vector<cfvec3>*>(&vertices)->push_back(vert); | 14:01 |
---|---|---|
blast007 | sane as in it's doing something wrong, or it just seems crazy? | 14:09 |
blast007 | before 2.4.4, it was ((std::vector<cfvec3>*)&vertices)->push_back(vert); | 14:11 |
tupone | the function is declared const | 14:11 |
tupone | so we are promising we do not change the objetc | 14:11 |
blast007 | ah | 14:13 |
tupone | maybe Flash can tell it better | 14:13 |
blast007 | should that be throwing a warning/error when we build that? | 14:13 |
tupone | yes, if I remove the const_cast | 14:14 |
blast007 | is it a "casts away qualifiers" warning? | 14:14 |
tupone | If I remove the cast it error out because we modify the object | 14:15 |
blast007 | ok | 14:15 |
tupone | and the compiler can make wrong optimization because of that | 14:16 |
tupone | maybe not in our case, who know | 14:16 |
tupone | I suggest to remove the const qualifier from all those virtual functions | 14:19 |
*** Cobra_Fast is now away: offline | 16:18 | |
*** Cobra_Fast is back | 16:18 | |
BZNotify | bzflag: atupone opened pull request #333 "Remove const attribute to writeToGroupDef" (https://github.com/BZFlag-Dev/bzflag/pull/333) | 18:03 |
*** FastLizard4 is back | 18:14 | |
*** FastLizard4 is now away: AWAY from keyboard | 18:21 | |
*** Sgeo <Sgeo!~Sgeo@user/sgeo> has joined #bzflag | 19:01 | |
*** FastLizard4 is back | 21:22 | |
*** FastLizard4 is now away: AWAY from keyboard | 21:22 | |
*** Zehra <Zehra!~Yukari@user/yukari> has joined #bzflag | 22:31 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!