*** joevano_ <joevano_!~joevano@bzflag/developer/JoeVano> has joined #bzflag | 00:22 | |
*** ChanServ sets mode: +v joevano_ | 00:22 | |
*** joevano <joevano!~joevano@bzflag/developer/JoeVano> has quit IRC (Ping timeout: 256 seconds) | 00:25 | |
*** I_Died_Once <I_Died_Once!~I_Died_On@unaffiliated/idiedonce/x-1828535> has quit IRC (Ping timeout: 260 seconds) | 02:04 | |
*** DTRemenak <DTRemenak!~DTRemenak@about/essy/CrazyCoder/DTRemenak> has quit IRC (Read error: Connection reset by peer) | 03:40 | |
*** DTRemenak <DTRemenak!~DTRemenak@2605:e000:141f:c002:a0b8:679f:3e7b:79c5> has joined #bzflag | 03:41 | |
*** ChanServ sets mode: +v DTRemenak | 03:41 | |
*** DTRemenak <DTRemenak!~DTRemenak@about/essy/CrazyCoder/DTRemenak> has quit IRC (Read error: No route to host) | 03:57 | |
*** DTRemenak <DTRemenak!~DTRemenak@2605:e000:141f:c002:a0b8:679f:3e7b:79c5> has joined #bzflag | 03:58 | |
*** ChanServ sets mode: +v DTRemenak | 03:58 | |
*** I_Died_Once <I_Died_Once!~I_Died_On@unaffiliated/idiedonce/x-1828535> has joined #bzflag | 10:24 | |
BZNotify | bzflag: macsforme synchronized pull request #251 "Fix multiple issues with SDL 2 window creation" (https://git.io/JfnZO) | 10:27 |
---|---|---|
macsforme | that should fix the ~8 times the window was being destroyed and re-created which was causing all the window flashes on Ubuntu... I'm still looking into the other issues | 10:30 |
blast007 | just tried my SDL2 fullscreen test on Windows and for some reason it doesn't resize the window to the full screen the first time I tell it to go fullscreen, so it's just a 640x480 borderless window in the top left corner :P | 11:07 |
*** blast007[m] <blast007[m]!blast007ma@gateway/shell/matrix.org/x-mduwpmchjevcmbmx> has quit IRC (*.net *.split) | 16:55 | |
*** CaptainRoberts[m <CaptainRoberts[m!generalpur@gateway/shell/matrix.org/x-ugibcrsjpfvvlltk> has quit IRC (Remote host closed the connection) | 16:56 | |
*** blast007[m] <blast007[m]!blast007ma@gateway/shell/matrix.org/x-ipplrkajurqkitie> has joined #bzflag | 17:02 | |
*** CaptainRoberts[m <CaptainRoberts[m!generalpur@gateway/shell/matrix.org/x-qpahfsmktjyfpvjw> has joined #bzflag | 17:25 | |
*** alfa1 <alfa1!~alfa1@host62.186-125-31.telecom.net.ar> has joined #bzflag | 18:37 | |
*** Sgeo <Sgeo!~Sgeo@ool-18b982ad.dyn.optonline.net> has joined #bzflag | 18:46 | |
*** alfa1 <alfa1!~alfa1@host62.186-125-31.telecom.net.ar> has quit IRC (Ping timeout: 258 seconds) | 19:46 | |
BZNotify | 2.4 @ bzflag: atupone pushed 1 commit (https://git.io/JJmzh): | 20:34 |
BZNotify | 2.4 @ bzflag: atupone 38b982: Add override consistently (https://git.io/JJmzj) | 20:34 |
*** joevano_ <joevano_!~joevano@bzflag/developer/JoeVano> has quit IRC (Remote host closed the connection) | 21:50 | |
macsforme | can anyone think of a better way to write this condition, without having to write out the SDL_PumpEvents() and SDL_GetWindowSize() lines twice? https://github.com/BZFlag-Dev/bzflag/pull/251/commits/fa3759e33c60d88faff995af7e8d02d74239da4c | 23:14 |
macsforme | I considered this for loop, a while loop, or a do-while loop, but was having a hard time coming up with something functionally identical | 23:16 |
blast007 | a do while loop where you break out of the loop if the width/height matches, with the loop condition being the check on the i counter? | 23:16 |
macsforme | so an if condition where if it matches, then break, otherwise sleep? | 23:17 |
blast007 | yeah | 23:18 |
the_map | maybe I'm missing something, but since those are and conditions, can't you just say i < 9 instead of i < 8? or is it important to not sleep one extra time? | 23:18 |
the_map | I see the comment saying "up to two seconds" but I don't know if that's a consequence or a necessity | 23:18 |
macsforme | I just don't want to sleep if it already matches on the first iteration | 23:19 |
macsforme | I was hoping to avoid the loop plus an if condition, but maybe it's not possible | 23:20 |
macsforme | the_map: are you saying the math is wrong for waiting up to two seconds? | 23:22 |
the_map | no, I wasn't sure if the intention was to not cross two seconds, or if two seconds is the known limit and you don't need to wait after that point | 23:23 |
the_map | if it's okay to cross two seconds then an extra sleep isn't too bad; but if it breaks something then you can't | 23:23 |
blast007 | maybe for 2.6 we can just pretend that display modes don't exist and just use SDL_WINDOW_FULLSCREEN_DESKTOP and scale the resolution with a shader :P | 23:24 |
macsforme | the idea was that it would wait for up to two seconds, but the continue on even if the resolutions still do not match | 23:29 |
macsforme | I think I like blast007's approach | 23:42 |
BZNotify | bzflag: macsforme synchronized pull request #251 "Fix multiple issues with SDL 2 window creation" (https://git.io/JfnZO) | 23:53 |
Generated by irclog2html.py 2.17.3.dev0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!