| macsforme | if we can address these two issues I think I'll be happy with it for now until we can give it a more fundamental refactor | 00:03 |
|---|---|---|
| blast007 | I still want to remove the code that has the game code notify the platform code about a resize | 00:03 |
| blast007 | it should be a one way notification, from the platform code to the game code | 00:03 |
| blast007 | the game code should only make requests on behalf of the user's wish | 00:03 |
| blast007 | but yes, that's a bigger refactor | 00:05 |
| blast007 | I have tried to do it a couple times in as small of a change as I can, but I keep breaking one platform or the other :) | 00:05 |
| blast007 | I think the window resize issue is because the game code is notifying the platform code about the resize, and then the platform code tells the game code about the resize | 00:07 |
| blast007 | and somewhere in that handling it's either calculating the dimensions differently or there's a calculation happening before and after the size has changed | 00:08 |
| macsforme | I wonder if it would be enough for the platform code to ignore resize events if in windowed mode... I think the only scenario where it needs to know about a resize is when changing the fullscreen resolution | 00:40 |
| macsforme | but I forget exactly where the call to resize() becomes a call to create()... that might be outside of the platform module | 00:41 |
| *** MarsIronPI <MarsIronPI!~user@173-16-160-11.client.mchsi.com> has joined #bzflag | 01:17 | |
| *** MarsIronPI <MarsIronPI!~user@173-16-160-11.client.mchsi.com> has left #bzflag ("ERC (IRC client for Emacs 26.1)") | 01:17 | |
| *** I_Died_Once <I_Died_Once!~I_Died_On@unaffiliated/idiedonce/x-1828535> has quit IRC (Ping timeout: 260 seconds) | 02:46 | |
| *** infobot <infobot!ibot@c-174-52-60-165.hsd1.ut.comcast.net> has quit IRC (Ping timeout: 260 seconds) | 04:25 | |
| *** infobot <infobot!ibot@c-174-52-60-165.hsd1.ut.comcast.net> has joined #bzflag | 04:42 | |
| *** ChanServ sets mode: +v infobot | 04:42 | |
| *** Sgeo <Sgeo!~Sgeo@ool-18b982ad.dyn.optonline.net> has quit IRC (Read error: Connection reset by peer) | 07:20 | |
| *** spldart <spldart!~spldart@bzflag/contributor/spldart> has quit IRC (Ping timeout: 260 seconds) | 08:28 | |
| *** spldart <spldart!~spldart@bzflag/contributor/spldart> has joined #bzflag | 08:33 | |
| *** ChanServ sets mode: +v spldart | 08:33 | |
| *** I_Died_Once <I_Died_Once!~I_Died_On@unaffiliated/idiedonce/x-1828535> has joined #bzflag | 08:56 | |
| blast007 | macsforme: I'll try to map out the logic tonight | 15:36 |
| *** Sgeo <Sgeo!~Sgeo@ool-18b982ad.dyn.optonline.net> has joined #bzflag | 22:49 | |
| *** DTRemenak <DTRemenak!~DTRemenak@about/essy/CrazyCoder/DTRemenak> has joined #bzflag | 23:31 | |
| *** ChanServ sets mode: +v DTRemenak | 23:31 | |
Generated by irclog2html.py 2.17.3.dev0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!