| *** Zehra <Zehra!~Zehra@unaffiliated/zehra> has joined #bzflag | 01:03 | |
| Zehra | Happy New Year. May this one be a successful year for BZFlag. | 05:04 |
|---|---|---|
| *** infobot <infobot!ibot@c-174-52-60-165.hsd1.ut.comcast.net> has joined #bzflag | 05:50 | |
| *** ChanServ sets mode: +v infobot | 05:50 | |
| *** Zehra <Zehra!~Zehra@unaffiliated/zehra> has quit IRC (Quit: Gone for now.) | 06:41 | |
| spldart | Weeeeee beeeeeeep | 07:34 |
| *** Sgeo <Sgeo!~Sgeo@ool-18b982ad.dyn.optonline.net> has joined #bzflag | 07:41 | |
| *** Sgeo <Sgeo!~Sgeo@ool-18b982ad.dyn.optonline.net> has quit IRC (Remote host closed the connection) | 07:42 | |
| *** Sgeo <Sgeo!~Sgeo@ool-18b982ad.dyn.optonline.net> has joined #bzflag | 07:42 | |
| *** Sgeo__ <Sgeo__!~Sgeo@ool-18b982ad.dyn.optonline.net> has quit IRC (Ping timeout: 258 seconds) | 07:42 | |
| BZNotify | bzflag: jwmelto synchronized pull request #236 "C++14" (https://git.io/Jebdt) | 08:36 |
| BZNotify | bzflag: jwmelto commented on pull request #236 "C++14" (https://git.io/JexvW): > As far as whether we actually want to change our C++ standard, th... | 08:45 |
| *** infobot <infobot!ibot@c-174-52-60-165.hsd1.ut.comcast.net> has quit IRC (Ping timeout: 265 seconds) | 09:35 | |
| BZNotify | bzflag: blast007 commented on pull request #236 "C++14" by jwmelto (https://git.io/JexTh): It looks like [some parts of C++14][1] need gcc 5 (or maybe even a ... | 14:28 |
| blast007 | Flash: can you explain a bit more about why the variables should be initialized before being passed to SDLDisplay::getWindowSize? getWindowSize isn't reading the values, only setting them. | 15:36 |
| blast007 | (in this https://github.com/blast007/bzflag/blob/refactor/sdl2createwindow/src/platform/SDL2Window.cxx#L183-L192 ) | 15:36 |
| *** fanta1 <fanta1!~fanta1@p200300F76BC3DC00CCE4B0BBFDE24DA5.dip0.t-ipconnect.de> has joined #bzflag | 16:40 | |
| *** spldart is now known as short_circuit | 17:06 | |
| *** ChanServ sets mode: -v short_circuit | 17:06 | |
| *** fanta1 <fanta1!~fanta1@p200300F76BC3DC00CCE4B0BBFDE24DA5.dip0.t-ipconnect.de> has quit IRC (Quit: fanta1) | 19:10 | |
| *** fanta1 <fanta1!~fanta1@p200300F76BC3DC00CCE4B0BBFDE24DA5.dip0.t-ipconnect.de> has joined #bzflag | 19:31 | |
| *** fanta1 <fanta1!~fanta1@p200300F76BC3DC00CCE4B0BBFDE24DA5.dip0.t-ipconnect.de> has quit IRC (Quit: fanta1) | 19:50 | |
| *** FusionDude <FusionDude!~flash@2601:280:c200:4e39:58ae:e1d4:8242:f434> has joined #bzflag | 20:52 | |
| *** ChanServ sets mode: +v FusionDude | 20:52 | |
| *** Flash <Flash!~flash@2601:280:c200:4e39:c5de:87a1:7362:61fe> has quit IRC (Ping timeout: 260 seconds) | 20:56 | |
| *** Zehra <Zehra!~Zehra@unaffiliated/zehra> has joined #bzflag | 21:15 | |
| *** FusionDude is now known as Flash | 21:19 | |
| Flash | blast007: it is a general principle on reducing cycolomatic complexity that all variables should be initialized. | 21:19 |
| Flash | in that particular case, the scope is pretty small, but an argument can be made that there is greater clarity in writing "these are my values, unless it's fullscreen, in which case we will get the display size" | 21:21 |
| Flash | instead of "there are two values that will be set at a later time, depending on the state of the fullscreen flag" | 21:22 |
| blast007 | would it be any different if there was instead a getTargetSize function that was immediately called to set the values? | 21:40 |
| blast007 | That's basically how it was before. I had moved the code from getSize into there, as I had changed getSize to return the current window size instead of the "soon to be" size | 21:40 |
| Flash | as I say, in a small scope, it's not that big of a deal | 21:41 |
| Flash | my experience is that C programmers are used to declaring all their variables up front; the C++ way is to define when you use | 21:42 |
| Flash | This case is middle ground; since POD don't have default constructors, you have the uninitialized case, but it doesn't last for long | 21:42 |
| Flash | it's not a hill I would die on (this example); just a quality improvement technique that doesn't adversely affect the readability of the code | 21:43 |
| Flash | feel free to ignore it, if you want | 21:44 |
| BZNotify | bzflag: jwmelto commented on pull request #236 "C++14" (https://git.io/JexGb): > So maybe the conversation should be around which features of newe... | 22:11 |
| *** Zehra <Zehra!~Zehra@unaffiliated/zehra> has quit IRC (Quit: Gone for now.) | 23:03 | |
Generated by irclog2html.py 2.17.3.dev0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!