*** Zehra <Zehra!~Yukari@user/yukari> has joined #bzflag | 00:47 | |
*** Flash <Flash!~Flash@user/flash> has quit IRC (Read error: Connection timed out) | 02:00 | |
*** Flash <Flash!~Flash@user/flash> has joined #bzflag | 02:00 | |
*** I_Died_Once <I_Died_Once!~I_Died_On@c-73-184-170-223.hsd1.ga.comcast.net> has joined #bzflag | 02:25 | |
*** Zehra <Zehra!~Yukari@user/yukari> has quit IRC (Quit: Quit.) | 03:25 | |
*** I_Died_Once <I_Died_Once!~I_Died_On@c-73-184-170-223.hsd1.ga.comcast.net> has quit IRC (Ping timeout: 240 seconds) | 03:56 | |
*** Cobra_Fast_ is now away: vacant | 05:04 | |
*** Cobra_Fast_ is back | 05:04 | |
*** Cobra_Fast_ is now away: vacant | 05:37 | |
*** Cobra_Fast_ is back | 05:37 | |
*** Cobra_Fast_ is now away: vacant | 06:11 | |
*** Cobra_Fast_ is back | 06:11 | |
*** Cobra_Fast_ is now away: vacant | 06:44 | |
*** Cobra_Fast_ is back | 06:44 | |
*** Sgeo <Sgeo!~Sgeo@user/sgeo> has quit IRC (Read error: Connection reset by peer) | 07:28 | |
*** BZNotify <BZNotify!BZNotify@2600:3c00::f03c:91ff:fe1f:d52a> has joined #bzflag | 07:43 | |
*** nitroxis <nitroxis!n@nxs.re> has joined #bzflag | 07:43 | |
*** blast007 <blast007!~blast@bzexcess.com> has joined #bzflag | 07:43 | |
*** TD-Linux <TD-Linux!~Thomas@user/td-linux> has joined #bzflag | 07:46 | |
*** Cobra_Fast_ is now away: vacant | 09:48 | |
*** FastLizard4 is back | 09:50 | |
*** Cobra_Fast_ is back | 09:52 | |
*** Cobra_Fast_ is now away: vacant | 09:53 | |
*** Cobra_Fast_ is back | 09:55 | |
*** Cobra_Fast_ is now away: vacant | 09:59 | |
*** Cobra_Fast_ is back | 10:06 | |
*** Cobra_Fast_ is now away: vacant | 10:07 | |
*** Cobra_Fast_ is back | 10:07 | |
*** FastLizard4 is now away: AWAY from keyboard | 10:17 | |
*** FastLizard4 is now away: GONE - Screen Detached and Disconnected from IRC (I'm probably asleep, at work, or doing something in real life) | 10:45 | |
*** I_Died_Once <I_Died_Once!~I_Died_On@c-73-184-170-223.hsd1.ga.comcast.net> has joined #bzflag | 11:04 | |
*** _I_Died_Once <_I_Died_Once!~I_Died_On@c-73-184-170-223.hsd1.ga.comcast.net> has joined #bzflag | 11:05 | |
*** I_Died_Once <I_Died_Once!~I_Died_On@c-73-184-170-223.hsd1.ga.comcast.net> has quit IRC (Ping timeout: 246 seconds) | 11:09 | |
blast007 | TimRiker: hmm, I'll have to think more about the host mismatch check... for a system that can talk to both v4 and v6, even a 2.4 game server might end up talking to the server list over IPv6, so the legacy list running on IPv6 could break most of the 2.4 servers if we keep the REMOTE_ADDR check. | 11:35 |
---|---|---|
*** Cobra_Fast_ is now away: vacant | 11:35 | |
*** Cobra_Fast_ is back | 11:35 | |
*** Cobra_Fast_ is now away: vacant | 13:23 | |
*** Cobra_Fast_ is back | 13:25 | |
*** Cobra_Fast_ is now away: vacant | 14:22 | |
*** Cobra_Fast_ is back | 14:23 | |
*** Cobra_Fast_ is now away: vacant | 14:23 | |
*** Cobra_Fast_ is back | 14:23 | |
*** Sgeo <Sgeo!~Sgeo@user/sgeo> has joined #bzflag | 15:01 | |
*** Cobra_Fast_ is now away: vacant | 16:06 | |
*** Cobra_Fast_ is back | 16:06 | |
TimRiker | In my changes: if the nameport matches the key, then the REMOTE_ADDR match is not required. If no key is present, then the REMOTE_ADDR needs to be one of the IPs in the name portion of nameport. This is true for both ADD and REMOVE. Old code currently does not send key on REMOVE, so that's worth considering. | 16:50 |
TimRiker | Currently if the list server has no ipv6 access, then any v6 ip in name would be ignored. I need to test a v6 only server still. I think it will work against my-dev which has v4 and v6, but I've not tested it yet. This could result in a server being on the list, that the list server can get to, but v4 only clients cannot. | 16:54 |
TimRiker | from the logs against my: 2023-04-12 15:13:03.564594: Peer ::ffff:144.217.83.100 connection timeout with data "" | 16:55 |
TimRiker | being able to see the ::ffff: has been useful in development. It's probably just confusing for admins, so I think I'll strip off that portion and show only the v4 portion of wrapped packets. Thoughts? | 16:57 |
blast007 | I'll have to do something about getting the current server able to communicate out via IPv6 | 17:18 |
blast007 | I have v6 disabled there right now to avoid leaking the IP | 17:18 |
TimRiker | my PR should work fine there without v6. it just won't handle v6 only servers, which is fine. | 17:20 |
blast007 | I need to look it all over more. It's a weird setup because we do have *inbound* IPv6, just not outbound. | 17:21 |
blast007 | (specifically, the load balancers can speak both IP families, but they then communicate with the app server over only v4) | 17:22 |
TimRiker | for v4 only clients sending keys on ADD and coming from their IP on REMOVE, it should work fine. my.bzflag.org only maps to v4 IPs so all incoming requests will currently be v4. | 17:24 |
blast007 | I should look into just exposing it directly | 17:24 |
TimRiker | For testing, i'd suggest we add a new dns name that points at v4 and v6, and test there before just adding v6 to my | 17:25 |
blast007 | the current feature_nameport branch might also fail if the bzfs is publishing with an IP instead of a hostname, since dns_get_record will return an empty array | 17:28 |
*** FastLizard4 is back | 17:31 | |
TimRiker | will it? oh. The old method I had worked with ips, but for v4 and v6. | 17:34 |
*** FastLizard4 is now away: AWAY from keyboard | 17:39 | |
TimRiker | php -r "var_dump(socket_addrinfo_explain(socket_addrinfo_lookup('127.0.0.1',5154,array('ai_socktype'=>SOCK_STREAM))[0]));" | 17:40 |
TimRiker | sounds like a reason for addrinfo instead of dns_get_record. | 17:41 |
TimRiker | php -r "var_dump(socket_addrinfo_explain(socket_addrinfo_lookup('127.0.0.1',5154,array('ai_socktype'=>SOCK_STREAM))[0])['ai_addr']);" | 17:42 |
TimRiker | I'll revert that change.... | 17:42 |
*** BulletCatcher <BulletCatcher!~bc@user/bulletcatcher> has quit IRC (Ping timeout: 276 seconds) | 17:52 | |
TimRiker | my-dev is running http2 which works great, just in case you are considering that. | 17:53 |
BZNotify | feature_nameport @ bzflag-bzfls: timriker pushed 1 commit (https://github.com/BZFlag-Dev/bzflag-bzfls/compare/2afcb629652e...667d2e0e5a9c): | 17:54 |
BZNotify | feature_nameport @ bzflag-bzfls: timriker 667d2e: dns_get_record() does not handle IPs in nameport. revert to addrinfo, which does (https://github.com/BZFlag-Dev/bzflag-bzfls/commit/667d2e0e5a9c8b76249be24da68cd1c8c553436b) | 17:54 |
BZNotify | bzflag-bzfls: timriker synchronized pull request #1 "Token nameport support" (https://github.com/BZFlag-Dev/bzflag-bzfls/pull/1) | 17:54 |
TimRiker | hmm. issues with adding a v6 only by ip and figuring out what's the port. working on it... | 18:08 |
blast007 | I was just doing a direct comparison of the published address and the REMOTE_ADDR if dns_get_record returned an empty array | 18:08 |
TimRiker | this method gets the ip back if given an ip, so it should work. | 18:09 |
BZNotify | feature_nameport @ bzflag-bzfls: timriker pushed 1 commit (https://github.com/BZFlag-Dev/bzflag-bzfls/compare/667d2e0e5a9c...685ee8e70dee): | 18:28 |
BZNotify | feature_nameport @ bzflag-bzfls: timriker 685ee8: handle raw ipv6:port, NOTE: port is required, even if default (https://github.com/BZFlag-Dev/bzflag-bzfls/commit/685ee8e70deecc3fdee86a578587132e320088af) | 18:28 |
BZNotify | bzflag-bzfls: timriker synchronized pull request #1 "Token nameport support" (https://github.com/BZFlag-Dev/bzflag-bzfls/pull/1) | 18:28 |
TimRiker | https://my-dev.bzflag.org/db/?action=LIST | 18:28 |
TimRiker | and without ip: https://my-dev.bzflag.org/db/?action=LIST&version=BZFS0225 | 18:29 |
TimRiker | still some work to do... bzadmin does not like it... Connecting to Tim Riker@2603:1030 using central login | 18:31 |
blast007 | You should have the IPv6 address contained within square brackets when you also specify a port | 18:32 |
blast007 | such as [2603:1030:c04:3::2c]:5154 | 18:32 |
TimRiker | yeah, not ready for that either... 2023-04-12 18:33:35.649058: Got line: "ERROR: cannot resolve [2603:1030:c04:3::2c]" | 18:34 |
TimRiker | I can work on adding that everywhere if that's what we want. so the list server would show the [] and presumably the listkeys would want a [] around the ip too? | 18:35 |
TimRiker | I guess if we do that then, [2603:1030:c04:3::2c] without a port would mean default port. | 18:37 |
blast007 | I was going to require hostnames for keys | 18:37 |
TimRiker | oh, I guess an ipv6 without [] would mean default port and []:port would only be required when on non-default port. | 18:38 |
TimRiker | I don't see an issue with that, other than the work required. I'll start on it. nameport []: it's v6 with port. more than one: it's v6 default port, has one : it's a name and a port or an v4 and port, no : it's name|v4 on default port. | 18:41 |
TimRiker | listkeys would have just the ip as it does not track ports. | 18:41 |
blast007 | we don't actually need to allow bare IPv6 addresses on the list | 18:42 |
TimRiker | yeah, but with that logic we can if we want. still need to do the same parsing on bzflag/bzadmin command line so people can connect to those different formats. | 18:43 |
blast007 | I'd say we deprecate support for bare IP publishing on the list and disable support for the creation of IP-based keys | 18:43 |
blast007 | sure, parsing on the command line would still be useful | 18:43 |
TimRiker | I'll see how much work it's going to take first. | 18:44 |
blast007 | but I think we don't have to worry about it on the list | 18:44 |
blast007 | I'd rather not have IPv6 only servers on the list anyway :) | 18:44 |
blast007 | still far too many people that won't have any v6 support | 18:45 |
blast007 | (or have broken v6 support) | 18:45 |
TimRiker | probably. | 18:45 |
BZNotify | feature_nameport @ bzflag-bzfls: timriker pushed 1 commit (https://github.com/BZFlag-Dev/bzflag-bzfls/compare/685ee8e70dee...7467e7d6a832): | 19:27 |
BZNotify | feature_nameport @ bzflag-bzfls: timriker 7467e7: [v6]:port support (https://github.com/BZFlag-Dev/bzflag-bzfls/commit/7467e7d6a8323de6848e7acc98e9f67028492d69) | 19:27 |
BZNotify | bzflag-bzfls: timriker synchronized pull request #1 "Token nameport support" (https://github.com/BZFlag-Dev/bzflag-bzfls/pull/1) | 19:27 |
*** tupone <tupone!~tupone@gentoo/developer/tupone> has quit IRC (Quit: leaving) | 20:26 | |
*** tupone <tupone!~tupone@gentoo/developer/tupone> has joined #bzflag | 20:26 | |
*** bryjen <bryjen!~bryjen@2603-6010-7a04-7681-0ad4-0cff-fe30-0e67.res6.spectrum.com> has joined #bzflag | 20:45 | |
*** BulletCatcher <BulletCatcher!~bc@user/bulletcatcher> has joined #bzflag | 20:58 | |
*** Zehra <Zehra!~Yukari@user/yukari> has joined #bzflag | 22:05 | |
*** bryjen <bryjen!~bryjen@2603-6010-7a04-7681-0ad4-0cff-fe30-0e67.res6.spectrum.com> has quit IRC (Quit: Leaving) | 23:19 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!