*** OkinaMatara <OkinaMatara!~Yukari@user/yukari> has joined #bzflag | 01:11 | |
*** I_Died_Once <I_Died_Once!~I_Died_On@c-73-184-170-223.hsd1.ga.comcast.net> has quit IRC (Ping timeout: 256 seconds) | 02:03 | |
*** I_Died_Once <I_Died_Once!~I_Died_On@c-73-184-170-223.hsd1.ga.comcast.net> has joined #bzflag | 02:16 | |
*** I_Died_Once <I_Died_Once!~I_Died_On@c-73-184-170-223.hsd1.ga.comcast.net> has quit IRC (Ping timeout: 256 seconds) | 02:20 | |
*** I_Died_Once <I_Died_Once!~I_Died_On@73.184.170.223> has joined #bzflag | 02:36 | |
*** OkinaMatara <OkinaMatara!~Yukari@user/yukari> has quit IRC (Quit: Quit.) | 03:28 | |
*** I_Died_Once <I_Died_Once!~I_Died_On@73.184.170.223> has quit IRC (Ping timeout: 240 seconds) | 05:35 | |
*** I_Died_Once <I_Died_Once!~I_Died_On@c-73-184-170-223.hsd1.ga.comcast.net> has joined #bzflag | 05:37 | |
*** Flash_ <Flash_!~Flash@user/flash> has joined #bzflag | 05:57 | |
*** SpringTank_ <SpringTank_!~quassel@69-154-138-57.lightspeed.rcsntx.sbcglobal.net> has joined #bzflag | 06:00 | |
*** yuitimothy_ <yuitimothy_!~yuitimoth@vps-022df355.vps.ovh.ca> has joined #bzflag | 06:00 | |
*** I_Died_Once <I_Died_Once!~I_Died_On@c-73-184-170-223.hsd1.ga.comcast.net> has quit IRC (*.net *.split) | 06:07 | |
*** Flash <Flash!~Flash@user/flash> has quit IRC (*.net *.split) | 06:07 | |
*** allejo <allejo!~allejo@user/allejo> has quit IRC (*.net *.split) | 06:07 | |
*** SpringTank <SpringTank!~quassel@69-154-138-57.lightspeed.rcsntx.sbcglobal.net> has quit IRC (*.net *.split) | 06:07 | |
*** yuitimothy <yuitimothy!~yuitimoth@user/yuitimothy> has quit IRC (*.net *.split) | 06:07 | |
*** nitroxis <nitroxis!n@nxs.re> has quit IRC (*.net *.split) | 06:07 | |
*** SpringTank_ is now known as SpringTank | 06:09 | |
*** I_Died_Once <I_Died_Once!~I_Died_On@c-73-184-170-223.hsd1.ga.comcast.net> has joined #bzflag | 06:12 | |
*** allejo <allejo!~allejo@user/allejo> has joined #bzflag | 06:12 | |
*** nitroxis <nitroxis!n@nxs.re> has joined #bzflag | 06:12 | |
*** erbium.libera.chat sets mode: +v allejo | 06:12 | |
*** Flash_ is now known as Flash | 08:08 | |
*** Sgeo <Sgeo!~Sgeo@user/sgeo> has quit IRC (Read error: Connection reset by peer) | 08:38 | |
*** I_Died_Once <I_Died_Once!~I_Died_On@c-73-184-170-223.hsd1.ga.comcast.net> has quit IRC (Read error: Connection reset by peer) | 09:45 | |
*** I_Died_Once <I_Died_Once!~I_Died_On@c-73-184-170-223.hsd1.ga.comcast.net> has joined #bzflag | 10:16 | |
*** Sgeo <Sgeo!~Sgeo@user/sgeo> has joined #bzflag | 14:05 | |
*** cods <cods!~fred@82-65-232-44.subs.proxad.net> has quit IRC (Ping timeout: 256 seconds) | 18:55 | |
*** cods <cods!~fred@82-65-232-44.subs.proxad.net> has joined #bzflag | 18:57 | |
tupone | blast007: tested ? | 19:18 |
---|---|---|
*** blast007[m] <blast007[m]!~blast007m@2001:470:69fc:105::7ec> has joined #bzflag | 19:18 | |
blast007 | it did work on Linux and I was building it on macos, but didn't test there yet | 19:18 |
blast007 | I also found at least one other game that also broke with 2.0.20, but some that work (while still using the same function call we do) | 19:19 |
blast007 | I'm planning to install Debian Testing on a system this weekend to test further | 19:19 |
blast007 | I'm curious why it works in prboom-plus and chocolate-doom (and probably crispy-doom, which wasn't packaged in Fedora) and rocksnddiamons (Rocks 'nd Diamonds), but not BZFlag and magicmirror | 19:22 |
blast007 | odd thing is that magicmirror and rocksnddiamons both seem to have similar codebases, so I'm hoping there's some hint there | 19:23 |
blast007 | rocksndiamonds* | 19:24 |
blast007 | mirrormagic* | 19:25 |
blast007 | rocksndiamonds does have some calls to SDL_PumpEvents() | 19:29 |
tupone | I will check if the event loop change can eventually work on all platform. Removing that "if" seems a good changes. Need to check all platform | 19:31 |
tupone | Then maybe we do not need the PeekEvent on the curl loop, as we drop the event received (except the esc). Maybe we can call the same SDL_Poll | 19:32 |
*** cods <cods!~fred@82-65-232-44.subs.proxad.net> has quit IRC (Ping timeout: 240 seconds) | 20:26 | |
*** cods <cods!~fred@82-65-232-44.subs.proxad.net> has joined #bzflag | 20:27 | |
tupone | My assumption is not valid for XDisplay.cxx. getEvent blocks when there is no event. Maybe no distribution uses the X platform | 20:38 |
blast007 | my plan for fixing it in 2.4 is for a minimal change | 20:49 |
blast007 | for 2.6 the intent was to get rid of other platform code and just go all in on SDL2 | 20:50 |
tupone | also WinDisplay getEvent seems to block | 21:02 |
tupone | the minimal change I suppose is putting a Pump in isEventPending | 21:04 |
blast007 | Yeah, the SDL_PumpEvents() thing might be enough for now | 21:07 |
blast007 | I'm curious if we need to only run that once per frame or if it needs to happen every time we call SDL_PollEvent(NULL) | 21:07 |
tupone | when not using curl we just call once per frame | 21:08 |
tupone | when downloading more then once | 21:09 |
tupone | well, more then once if frame rate is very slow. It is called as part of the progressFunction | 21:11 |
BZNotify | bzflag: atupone commented on pull request #302 "Do not use isEventPending to exit from event loop" (https://github.com/BZFlag-Dev/bzflag/pull/302#issuecomment-1024651929): It works only for SDL | 21:27 |
BZNotify | bzflag: atupone closed pull request #302 | 21:27 |
Generated by irclog2html.py 2.17.3.dev0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!