*** OkinaMatara <OkinaMatara!~Yukari@user/yukari> has joined #bzflag | 02:02 | |
*** disco <disco!~disco@81.187.95.100> has quit IRC (Remote host closed the connection) | 02:08 | |
*** disco <disco!~disco@81.187.95.100> has joined #bzflag | 02:30 | |
*** OkinaMatara <OkinaMatara!~Yukari@user/yukari> has quit IRC (Quit: Quit.) | 04:34 | |
*** kj4 <kj4!~kj4@24.88.35.135> has joined #bzflag | 04:57 | |
blast007 | also replicated it in one of their test programs (testmouse.c) | 04:58 |
---|---|---|
blast007 | seems none of their tests use SDL_PollEvent(NULL) to check if there are any pending events | 04:58 |
kj4 | hello all | 05:01 |
blast007 | hi | 05:01 |
*** kj4 <kj4!~kj4@24.88.35.135> has quit IRC (Quit: Leaving) | 05:05 | |
blast007 | I also just tried always returning true from isEventPending and that had a major FPS hit. | 05:06 |
blast007 | oh, I guess cuz we loop calling doEvent if events are pending, up to the max processing time, up to 100ms, so that explains my 9 FPS :) | 05:07 |
blast007 | sent some messages to the wrong channel, so pretend these next three lines were from before my messages about replicating it in testmouse.c :) | 05:24 |
blast007 | < blast007> if I replace SDL_PollEvent with SDL_WaitEventTimeout and pass 1 for the timeout (for 1 millisecond) it works again | 05:24 |
blast007 | < blast007> more specifically, it seems I only need to replace the SDL_PollEvent(NULL) in SDLDisplay::isEventPending (in SDL2Display.cxx) with SDL_WaitEventTimeout(NULL, 1) | 05:24 |
blast007 | < blast007> when I wrap event processing with 'if (SDL_PollEvent(NULL) == 1)' in another test program I have it too no longer accepts input and throws up a not responding message | 05:24 |
*** I_Died_Once <I_Died_Once!~I_Died_On@c-73-184-170-223.hsd1.ga.comcast.net> has quit IRC (Ping timeout: 240 seconds) | 06:10 | |
tupone | running Pump_Event does help ? | 07:52 |
tupone | SDL_PumpEvents | 07:52 |
*** Sgeo <Sgeo!~Sgeo@user/sgeo> has quit IRC (Read error: Connection reset by peer) | 07:59 | |
*** blast007[m] <blast007[m]!~blast007m@2001:470:69fc:105::7ec> has quit IRC (Quit: You have been kicked for being idle) | 09:00 | |
*** joes <joes!~joes@hardfought/member/joes> has joined #bzflag | 10:38 | |
*** I_Died_Once <I_Died_Once!~I_Died_On@c-73-184-170-223.hsd1.ga.comcast.net> has joined #bzflag | 11:33 | |
blast007 | tupone: ah, good catch. That does in fact help. | 12:42 |
*** blast007[m] <blast007[m]!~blast007m@2001:470:69fc:105::7ec> has joined #bzflag | 12:42 | |
tupone | good | 12:53 |
tupone | maybe there is a bug in SDL, as it says it is automatically called | 12:54 |
blast007 | I had someone in SDL tell me that SDL_PollEvent(NULL) was "never meant for checking for pending events", but that seems to contradict the documentation | 12:55 |
blast007 | in #SDL* | 12:55 |
blast007 | maybe I'll get some better responses when other people wake up | 12:56 |
tupone | :) | 12:56 |
blast007 | I intend to submit it as an issue on SDL's github repo today | 12:56 |
*** joes <joes!~joes@hardfought/member/joes> has quit IRC (Remote host closed the connection) | 14:29 | |
*** joes <joes!~joes@hardfought/member/joes> has joined #bzflag | 14:32 | |
*** Sgeo <Sgeo!~Sgeo@user/sgeo> has joined #bzflag | 15:19 | |
BZNotify | bzflag: atupone opened pull request #302 "Do not use isEventPending to exit from event loop" (https://github.com/BZFlag-Dev/bzflag/pull/302) | 18:30 |
tupone | need to check on all platforms :/ | 18:30 |
*** joes <joes!~joes@hardfought/member/joes> has quit IRC (Ping timeout: 268 seconds) | 18:34 | |
BZNotify | bzflag: atupone synchronized pull request #302 "Do not use isEventPending to exit from event loop" (https://github.com/BZFlag-Dev/bzflag/pull/302) | 18:54 |
tupone | for SDL2 should be ok | 18:55 |
tupone | https://github.com/libsdl-org/SDL/commit/84320266f2fec31c79f1bf7267288c6f30a06365 | 19:05 |
tupone | maybe that fixes it | 19:06 |
*** a_meteorite <a_meteorite!~bzmeteori@user/a-meteorite/x-8451676> has quit IRC (Quit: My MacBook has gone to sleep. ZZZzzz…) | 19:54 | |
BZNotify | bzflag: atupone synchronized pull request #302 "Do not use isEventPending to exit from event loop" (https://github.com/BZFlag-Dev/bzflag/pull/302) | 20:41 |
BZNotify | bzflag: atupone edited pull request #302 "Do not use isEventPending to exit from event loop" (https://github.com/BZFlag-Dev/bzflag/pull/302) | 20:47 |
Generated by irclog2html.py 2.17.3.dev0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!