| *** Optic_Delusion <Optic_Delusion!~Optic_Del@pool-71-182-231-53.pitbpa.fios.verizon.net> has quit IRC (Quit: Textual IRC Client: www.textualapp.com) | 03:28 | |
| *** Optic_Delusion <Optic_Delusion!~Optic_Del@pool-71-182-231-53.pitbpa.fios.verizon.net> has joined #bzflag | 03:31 | |
| *** Sgeo <Sgeo!~Sgeo@user/sgeo> has quit IRC (Read error: Connection reset by peer) | 07:34 | |
| *** moriah <moriah!~quassel@user/kierra> has quit IRC (Remote host closed the connection) | 08:59 | |
| *** blast007[m] <blast007[m]!~blast007m@2001:470:69fc:105::7ec> has quit IRC (Quit: You have been kicked for being idle) | 09:00 | |
| *** kierra <kierra!~quassel@104.243.40.186> has joined #bzflag | 09:00 | |
| *** kierra is now known as moriah | 12:17 | |
| *** Sgeo <Sgeo!~Sgeo@user/sgeo> has joined #bzflag | 13:47 | |
| BZNotify | bzflag: The-Noah synchronized pull request #291 "GitHub action to ensure BZFlag builds" (https://git.io/JiCg8) | 15:24 |
|---|---|---|
| *** blast007[m] <blast007[m]!~blast007m@2001:470:69fc:105::7ec> has joined #bzflag | 15:25 | |
| blast007 | somewhere I have the start of improvements for the build action | 15:32 |
| blast007 | I was trying to make it possible to test builds on Linux, macOS, and Windows | 15:33 |
| blast007 | hmm, I guess I was messing around with the CodeQL action, not our build action | 15:34 |
| blast007 | also our current build action disables the client | 15:34 |
| blast007 | current CodeQL action* | 15:36 |
| blast007 | is doing both a build and a CodeQL action redundant? | 15:40 |
| *** blast007[m] <blast007[m]!~blast007m@2001:470:69fc:105::7ec> has quit IRC (Quit: You have been kicked for being idle) | 16:00 | |
| BZNotify | bzflag: The-Noah commented on pull request #291 "GitHub action to ensure BZFlag builds" (https://git.io/JilHn): Thanks! I've fixed it as seen [here](https://github.com/BZFlag-Dev/... | 16:19 |
| *** blast007[m] <blast007[m]!~blast007m@2001:470:69fc:105::7ec> has joined #bzflag | 16:19 | |
| *** tupone <tupone!~tupone@gentoo/developer/tupone> has quit IRC (Remote host closed the connection) | 19:40 | |
| *** tupone <tupone!~tupone@gentoo/developer/tupone> has joined #bzflag | 19:49 | |
| BZNotify | bzflag: allejo review_requested pull request #291 "GitHub action to ensure BZFlag builds" by The-Noah (https://git.io/JiCg8) | 19:54 |
| allejo | i'll defer 291 to your blast007. i think a separate CodeQL action works as it only focuses on analyzing the code files and doesn't have to worry about building it (if i'm understanding how the CodeQL action works) | 19:54 |
| allejo | I'd want the build action to build on macOS and Windows too though. and CodeQL to focus on the code itself | 19:55 |
| blast007 | https://github.com/BZFlag-Dev/bzflag/blob/2.4/.github/workflows/codeql-analysis.yml#L39-L42 it does a build | 19:55 |
| allejo | does codeql need a build? | 19:56 |
| blast007 | there's several "closed" CodeQL issues that I don't understand why are closed, since I don't think the issue is actually fixed | 19:56 |
| blast007 | don't know | 19:56 |
| blast007 | their examples do compile the code | 19:57 |
| blast007 | https://github.com/github/codeql-action | 19:57 |
| allejo | the security tab says you fixed those codeql issues lol | 19:58 |
| blast007 | with a very unrelated commit, IIRC | 19:58 |
| blast007 | think it said I fixed them with the OBS Studio fix | 19:58 |
| allejo | yah it did | 19:58 |
| blast007 | so.. is CodeQL even working right? :P | 19:58 |
| allejo | looks like you do need a build, https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-the-codeql-workflow-for-compiled-languages#adding-build-steps-for-a-compiled-language | 19:59 |
| allejo | like it'll autobuild if you don't specify how to build a compiled language | 19:59 |
| blast007 | the key bit is "For the compiled languages C/C++, C#, and Java, the process of populating this database involves building the code and extracting data." | 20:00 |
| allejo | the calls to `ctime` are still there in commands.cxx, not sure how CodeQL considered them fixed. maybe we're not specifying how to extract data from our builds? | 20:01 |
| blast007 | maybe the build is failing and thus the database isn't populated, so it has nothing to look at? | 20:07 |
| *** Harlin <Harlin!~DonQixote@c-24-128-8-53.hsd1.co.comcast.net> has quit IRC (Quit: Leaving) | 20:20 | |
| allejo | potentially? worth investigating | 21:43 |
| allejo | if PR 291 was updated to build on macOS and Windows as well, i'd be cool with it and would favor a seperate workflow dedicated to just ensuring everything builds | 21:44 |
| *** I_Died_Once <I_Died_Once!~I_Died_On@c-73-184-170-223.hsd1.ga.comcast.net> has joined #bzflag | 23:00 | |
Generated by irclog2html.py 2.17.3.dev0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!