| *** _I_Died_Once <_I_Died_Once!~I_Died_On@unaffiliated/idiedonce/x-1828535> has joined #bzflag | 00:31 | |
| *** I_Died_Once <I_Died_Once!~I_Died_On@unaffiliated/idiedonce/x-1828535> has quit IRC (Ping timeout: 256 seconds) | 00:35 | |
| *** _I_Died_Once <_I_Died_Once!~I_Died_On@unaffiliated/idiedonce/x-1828535> has quit IRC (Ping timeout: 246 seconds) | 00:39 | |
| *** I_Died_Once <I_Died_Once!~I_Died_On@unaffiliated/idiedonce/x-1828535> has joined #bzflag | 00:49 | |
| blast007 | macsforme: I'd be curious if this workaround is unnecessary now that SDL 2.0.12 is out, which should have that fix: https://github.com/BZFlag-Dev/bzflag/commit/30ed1b47f9cbb81bfb9bc4a6eb37775d4d9121ef | 04:01 |
|---|---|---|
| blast007 | planning on releasing 2.4.20 on Friday | 04:02 |
| blast007 | what should we call it? | 04:02 |
| allejo | 2.4.20 "Meh" | 04:07 |
| The_Noah | :p | 04:07 |
| The_Noah | "No More Hunting Rabbits" ? in reference to https://github.com/BZFlag-Dev/bzflag/commit/bb49edf289cffd58bf307da86fbc8b8410bd4914 | 04:09 |
| blast007 | allejo: bz_isWithinWorldBoundaries will fail when _disableHeightChecks is enabled since bz_getWorldMaxHeight will return -1 | 04:30 |
| allejo | I guess at that point, I shouldn't check the Z pos since height checks are disabled, right? | 04:31 |
| allejo | well max Z. min Z should remain 0 | 04:32 |
| blast007 | if (pos[2] > maxZ) ===> if (maxZ >= 0.0 && pos[2] > maxZ) | 04:32 |
| blast007 | or 0.0f, since we're comparing floats | 04:33 |
| allejo | does burrow technically escape world boundaries if we do 0.0f? | 04:33 |
| blast007 | that part isn't checking for underground, just too high | 04:34 |
| allejo | ah lemme pull up the code whenever xcode decides to finish updating | 04:35 |
| *** infobot <infobot!ibot@c-174-52-60-165.hsd1.ut.comcast.net> has joined #bzflag | 04:36 | |
| *** ChanServ sets mode: +v infobot | 04:36 | |
| blast007 | I'm also wondering if we should go back to duplicating some of the bz_isWithinWorldBoundaries code inside of bz_getSpawnPointWithin. As it is right now, we're doing two BZDB parsing operations each attempt, up to 50 attempts, whereas before we only did two BZDB parsing events in regardless of how many attempts it took. | 04:37 |
| blast007 | probably less of a big deal for the server | 04:37 |
| allejo | ahhh yea, i did take burrow into consideration there but not disabled height checks | 04:38 |
| allejo | i see what you mean about the bzdb parsing. your call, i just didn't want to repeat that logic twice but you're right, we're parsing bzdb way more | 04:41 |
| blast007 | I'll think about it more when I'm less sleepy :) | 04:42 |
| allejo | mkay. i'll push the -1 check | 04:43 |
| blast007 | k, thanks | 04:43 |
| BZNotify | 2.4 @ bzflag: allejo pushed 1 commit (https://git.io/JfTKb): | 04:45 |
| BZNotify | 2.4 @ bzflag: allejo 040b45: Fix bz_isWithinWorldBoundaries when height checks are disabled (https://git.io/JfTKN) | 04:45 |
| BZNotify | bzflag: allejo labeled issue #248 "Rewrite BZDB to be a smarter structure" as enhancement (2.6 Release - https://git.io/JfT6e) | 04:53 |
| BZNotify | bzflag: allejo opened issue #248 (2.6 Release - ) | 04:53 |
| BZNotify | bzflag: allejo milestoned issue #248 (2.6 Release - ) | 04:53 |
| BZNotify | bzflag: allejo edited issue #248 "Rewrite BZDB to be a smarter structure" (2.6 Release - https://git.io/JfT6e) | 04:56 |
| BZNotify | bzflag: The-Noah opened pull request #249 "Fix autogen having CRLF line endings" (https://git.io/JfT61) | 05:42 |
| macsforme | blast007: as long as 4177 made it into an official SDL release, I think we're good to remove that workaround... that was one of the steps in my big issue I made of all the SDL window issues | 06:54 |
| macsforme | are we going to release 2.4.20 without fixing the SDL window problems? | 06:54 |
| *** dcat <dcat!~dcat@c-98-244-106-246.hsd1.va.comcast.net> has quit IRC (Excess Flood) | 07:09 | |
| *** dcat <dcat!~dcat@c-98-244-106-246.hsd1.va.comcast.net> has joined #bzflag | 07:10 | |
| *** infobot <infobot!ibot@c-174-52-60-165.hsd1.ut.comcast.net> has quit IRC (Ping timeout: 260 seconds) | 08:54 | |
| blast007 | macsforme: I haven't been able to fix the SDL window problems | 11:06 |
| *** DTRemenak|RDP <DTRemenak|RDP!~DTRemenak@2605:e000:141f:c002:843a:b315:8a75:5f9a> has joined #bzflag | 21:21 | |
| *** ChanServ sets mode: +v DTRemenak|RDP | 21:21 | |
| *** DTRemenak <DTRemenak!~DTRemenak@about/essy/CrazyCoder/DTRemenak> has quit IRC (Ping timeout: 272 seconds) | 21:23 | |
| *** DTRemenak|RDP is now known as DTRemenak | 21:23 | |
Generated by irclog2html.py 2.17.3.dev0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!